linux-kernel - RE: [PATCH] scsi: ufshpb: Properly handle max-single-cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 01 Nov 2021 16:22:58 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Avri Altman <avri.altman@....com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>,
        Daejun Park <daejun7.park@...sung.com>
Subject: RE: [PATCH] scsi: ufshpb: Properly handle max-single-cmd

Hi Avri,

> The spec recommends that for transfer length larger than the
> max-single-cmd attribute (bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD) it is
> possible to couple pre-reqs with the HPB-READ command.  Being a
> recommendation, using pre-reqs can be perceived merely as a mean of
> optimization.  A common practice was to send pre-reqs for chunks within
> some interval, and leave the READ10 untouched if larger.
>  
> Anyway, now that the pre-reqs flows have been opt-out, all the commands
> are single commands.  So properly handle this attribute and do not send
> HPB-READ for transfer lengths larger than max-single-cmd.
>  
> Fixes: 09d9e4d04187 (scsi: ufs: ufshpb: Remove HPB2.0 flows)
>  
> Signed-off-by: Avri Altman <avri.altman@....com>
> ---
>  drivers/scsi/ufs/ufshpb.c | 29 +++++++++++++++--------------
>  drivers/scsi/ufs/ufshpb.h |  1 -
>  2 files changed, 15 insertions(+), 15 deletions(-)

Reviewed-by: Daejun Park <daejun7.park@...sung.com>