linux-kernel - Re: [PATCH v7 9/9] eni_vdpa: alibaba: fix Kconfig typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Nov 2021 04:18:32 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Wu Zongyong <wuzongyong@...ux.alibaba.com>
Cc:     jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, wei.yang1@...ux.alibaba.com,
        Arnd Bergmann <arnd@...db.de>,
        Stefano Garzarella <sgarzare@...hat.com>
Subject: Re: [PATCH v7 9/9] eni_vdpa: alibaba: fix Kconfig typo

On Fri, Oct 29, 2021 at 05:14:50PM +0800, Wu Zongyong wrote:
> The Kconfig symbol was misspelled, which leads to randconfig link
> failures:
> 
> ld.lld: error: undefined symbol: vp_legacy_probe
> >>> referenced by eni_vdpa.c
> >>>               vdpa/alibaba/eni_vdpa.o:(eni_vdpa_probe) in archive drivers/built-in.a
> 
> Fixes: 6a9f32c00609 ("eni_vdpa: add vDPA driver for Alibaba ENI")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>
> Signed-off-by: Wu Zongyong <wuzongyong@...ux.alibaba.com>

This one I'll squash into the previous one. That commit hash is not
going to match anything useful.

> ---
>  drivers/vdpa/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 07b0c73212aa..50f45d037611 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -80,7 +80,7 @@ config VP_VDPA
>  
>  config ALIBABA_ENI_VDPA
>  	tristate "vDPA driver for Alibaba ENI"
> -	select VIRTIO_PCI_LEGACY_LIB
> +	select VIRTIO_PCI_LIB_LEGACY
>  	depends on PCI_MSI && X86
>  	help
>  	  VDPA driver for Alibaba ENI (Elastic Network Interface) which is built upon
> -- 
> 2.31.1