linux-kernel - Re: Need help in debugging "memory leak in em28xx_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f622f569-25d5-f38e-e9fb-7f07e12c4b7e@gmail.com>
Date:   Mon, 1 Nov 2021 12:19:45 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: Need help in debugging "memory leak in em28xx_init_dev"

On 11/1/21 11:55, Dongliang Mu wrote:

>>
>>
>> Looks like missing clean up on error handling path.
>>
>> ->probe()
>>      em28xx_init_dev()
>>        em28xx_media_device_init() <- dev->media_dev allocated
>>        *error somewhere in em28xx_init_dev()*
>>
> 
> Hi Pavel,
> 
> you're right. In some error handling code (em28xx_audio_setup fails),
> em28xx_init_dev fails to deallocated the media_dev field.
> 

Hi, Dongliang,

Did patch attached to my previous email pass syzbot's reproducer test? 
Unfortunately, I am not able to test rn :(




With regards,
Pavel Skripkin