linux-kernel - Re: [PATCH] iommu/dma: fix incorrect error return on iommu deferred attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ad0367d-1242-1c41-ad7c-6c4cc4f70983@huawei.com>
Date:   Mon, 1 Nov 2021 09:21:20 +0000
From:   John Garry <john.garry@...wei.com>
To:     Logan Gunthorpe <logang@...tatee.com>,
        <linux-kernel@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
        Christoph Hellwig <hch@....de>
CC:     Will Deacon <will@...nel.org>,
        Marshall Midden <marshallmidden@...il.com>
Subject: Re: [PATCH] iommu/dma: fix incorrect error return on iommu deferred
 attach

On 27/10/2021 18:47, Logan Gunthorpe wrote:
> scsi_dma_map() was reporting a failure during boot on an AMD machine
> with the IOMMU enabled.
> 
>    scsi_dma_map failed: request for 36 bytes!
> 
> The issue was tracked down to a mistake in logic: should not return
> an error if iommu_deferred_attach() returns zero.
> 
> Reported-by: Marshall Midden<marshallmidden@...il.com>
> Fixes: dabb16f67215 ("iommu/dma: return error code from iommu_dma_map_sg()")
> Link:https://lore.kernel.org/all/CAD2CkAWjS8=kKwEEN4cgVNjyFORUibzEiCUA-X+SMtbo0JoMmA@mail.gmail.com
> Signed-off-by: Logan Gunthorpe<logang@...tatee.com>
> Cc: Joerg Roedel<joro@...tes.org>
> Cc: Will Deacon<will@...nel.org>

Seems reasonable, FWIW:
Reviewed-by: John Garry <john.garry@...wei.com>