linux-kernel - Re: [PATCH] parisc: using swap() instead of tmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YX9PNEEiaFn803RF@casper.infradead.org>
Date:   Mon, 1 Nov 2021 02:21:40 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Yihao Han <hanyihao@...o.com>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        David Hildenbrand <david@...hat.com>,
        Christophe Leroy <christophe.leroy@....fr>,
        Sven Schnelle <svens@...ckframe.org>,
        linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...o.com
Subject: Re: [PATCH] parisc: using swap() instead of tmp

On Sun, Oct 31, 2021 at 07:10:45PM -0700, Yihao Han wrote:
> @@ -127,16 +127,13 @@ static void __init setup_bootmem(void)
>  		int j;
>  
>  		for (j = i; j > 0; j--) {
> -			physmem_range_t tmp;
>  

If you're going to delete that line, you should also delete the
blank line after it.

>  			if (pmem_ranges[j-1].start_pfn <
>  			    pmem_ranges[j].start_pfn) {
>  
>  				break;
>  			}
> -			tmp = pmem_ranges[j-1];
> -			pmem_ranges[j-1] = pmem_ranges[j];
> -			pmem_ranges[j] = tmp;
> +			swap(pmem_ranges[j-1], pmem_ranges[j]);
>  		}
>  	}
>  
> -- 
> 2.17.1
>