linux-kernel - Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211101094641.cseo7fvrzyzh2pkl@tp>
Date:   Mon, 1 Nov 2021 10:46:41 +0100
From:   Florian Klink <flokli@...kli.de>
To:     Dennis Gilmore <dgilmore@...hat.com>
Cc:     linux-rockchip@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: helios64: add variables for pcie
 completion

Acked-By: Florian Klink <flokli@...kli.de>

On 21-10-28 19:53:19, Dennis Gilmore wrote:
>without ep-gpios defined u-boot does not initialise PCIe
>rockchip_pcie pcie@...00000: failed to find ep-gpios property
>
>additionally set max-link-speed and pinctrl-names for completeness
>
>with this patch and the ones from Florian Klink applied to the dts
>file in u-boot sata drives show up in both u-boot and linux
>
>Signed-off-by: Dennis Gilmore <dgilmore@...hat.com>
>---
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>index 9c2b45012daa..1e4042a7fdc3 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
>@@ -534,7 +534,10 @@ &pcie_phy {
> };
>
> &pcie0 {
>+	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
>+	max-link-speed = <2>;
> 	num-lanes = <2>;
>+	pinctrl-names = "default";
> 	status = "okay";
>
> 	vpcie12v-supply = <&vcc12v_dcin>;
>-- 
>2.32.0

-- 
Florian Klink