linux-kernel - Re: [PATCH] pci/controller/pcie-apple: remove the indentation beside arguments of DECLARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878ry89nfp.wl-maz@kernel.org>
Date:   Mon, 01 Nov 2021 10:31:54 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Zhaoyu Liu <zackary.liu.pro@...il.com>
Cc:     alyssa@...enzweig.io, lorenzo.pieralisi@....com, robh@...nel.org,
        kw@...ux.com, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci/controller/pcie-apple: remove the indentation beside arguments of DECLARE_BITMAP

On Sun, 31 Oct 2021 13:55:48 +0000,
Zhaoyu Liu <zackary.liu.pro@...il.com> wrote:
> 
> When "make tags", it prompts a warning:
> 
>     ctags: Warning: drivers/pci/controller/pcie-apple.c:150:
>     null expansion of name pattern "\1"
> 
> Ctags regular can not be matched due to indentation, so remove it.
> Same fix as in commit 5fdf876d30ce ("KVM: arm: Do not indent
> the arguments of DECLARE_BITMAP")
> 
> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@...il.com>
> ---
>  drivers/pci/controller/pcie-apple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> index b665d29af77a..955134464d84 100644
> --- a/drivers/pci/controller/pcie-apple.c
> +++ b/drivers/pci/controller/pcie-apple.c
> @@ -147,7 +147,7 @@ struct apple_pcie_port {
>  	void __iomem		*base;
>  	struct irq_domain	*domain;
>  	struct list_head	entry;
> -	DECLARE_BITMAP(		sid_map, MAX_RID2SID);
> +	DECLARE_BITMAP(sid_map, MAX_RID2SID);
>  	int			sid_map_sz;
>  	int			idx;
>  };

This really feels like we're papering over a tooling bug. Other
tagging systems do not seem to suffer from this (I use gtags myself).

It is easily fixed with the following patch, at least with my
setup. Can you please give it a go?

Thanks,

	M.

diff --git a/scripts/tags.sh b/scripts/tags.sh
index b24bfaec6290..7e5f19391f20 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -186,7 +186,7 @@ regex_c=(
 	'/\<DEFINE_\(RT_MUTEX\|MUTEX\|SEMAPHORE\|SPINLOCK\)(\([[:alnum:]_]*\)/\2/v/'
 	'/\<DEFINE_\(RAW_SPINLOCK\|RWLOCK\|SEQLOCK\)(\([[:alnum:]_]*\)/\2/v/'
 	'/\<DECLARE_\(RWSEM\|COMPLETION\)(\([[:alnum:]_]\+\)/\2/v/'
-	'/\<DECLARE_BITMAP(\([[:alnum:]_]*\)/\1/v/'
+	'/\<DECLARE_BITMAP([[:space:]]*\([[:alnum:]_]*\)/\1/v/'
 	'/\(^\|\s\)\(\|L\|H\)LIST_HEAD(\([[:alnum:]_]*\)/\3/v/'
 	'/\(^\|\s\)RADIX_TREE(\([[:alnum:]_]*\)/\2/v/'
 	'/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'


-- 
Without deviation from the norm, progress is not possible.