linux-kernel - Re: [PATCH] samples: remove duplicate include in fs-monitor.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211101121819.GD21679@quack2.suse.cz>
Date:   Mon, 1 Nov 2021 13:18:19 +0100
From:   Jan Kara <jack@...e.cz>
To:     cgel.zte@...il.com
Cc:     jack@...e.cz, zhang.mingyu@....com.cn, krisman@...labora.com,
        amir73il@...il.com, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] samples: remove duplicate include in fs-monitor.c

On Mon 01-11-21 07:51:52, cgel.zte@...il.com wrote:
> From: Zhang Mingyu <zhang.mingyu@....com.cn>
> 
> 'sys/types.h' included in 'samples/fanotify/fs-monitor.c'
> is duplicated.It is also included on 15 line.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Zhang Mingyu <zhang.mingyu@....com.cn>

Thanks. I've added the patch to my tree.

									Honza

> ---
>  samples/fanotify/fs-monitor.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/samples/fanotify/fs-monitor.c b/samples/fanotify/fs-monitor.c
> index a0e44cd31e6f..0a5f742a77a8 100644
> --- a/samples/fanotify/fs-monitor.c
> +++ b/samples/fanotify/fs-monitor.c
> @@ -12,7 +12,6 @@
>  #include <sys/fanotify.h>
>  #include <sys/types.h>
>  #include <unistd.h>
> -#include <sys/types.h>
>  
>  #ifndef FAN_FS_ERROR
>  #define FAN_FS_ERROR		0x00008000
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR