linux-kernel - Re: Need help in debugging "memory leak in em28xx_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD-N9QUcoKnEWw98XnBJZkas3AkwPonNG0K-PMROOwn8kReT5g@mail.gmail.com>
Date:   Mon, 1 Nov 2021 20:23:29 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: Need help in debugging "memory leak in em28xx_init_dev"

On Mon, Nov 1, 2021 at 8:17 PM Pavel Skripkin <paskripkin@...il.com> wrote:
>
> On 11/1/21 12:58, Dongliang Mu wrote:
> > On Mon, Nov 1, 2021 at 5:43 PM Pavel Skripkin <paskripkin@...il.com> wrote:
> >>
> >> On 11/1/21 12:41, Dongliang Mu wrote:
> >> >> Hi, Dongliang,
> >> >>
> >> >> Did patch attached to my previous email pass syzbot's reproducer test?
> >> >> Unfortunately, I am not able to test rn :(
> >> >
> >> > Yes, it works. The memory leak does not occur anymore.
> >> >
> >> > But I am crafting another patch based on yours as there is a small
> >> > issue in the retval and I would like to make the error handling code
> >> > uniform.
> >> >
> >>
> >> Cool! Thank you for confirmation.
> >
> > Hi Pavel,
> >
> > Thanks for your advice. I have sent the patch and you are on the CC
> > list. Can you please take a look at and review my patch?
> >
> > It should cover your patch. But I am not sure if I introduce any new
> > issue in the patch.
> >
>
> The patch LGTM, but I can't drop R-b tag, since I am not an expert in
> this driver. Anyway, there is 100% missing clean up, so, I believe, you
> don't introduce new bugs

drop? I do see some patches from local syzkaller will attach this tag
to assign credits to syzkaller/syzbot.

I think this form is good. Thus I copy this tag from them.

>
>
>
> With regards,
> Pavel Skripkin