linux-kernel - Re: [PATCH] hid: playstation: add LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2111011535190.12554@cbobk.fhfr.pm>
Date:   Mon, 1 Nov 2021 15:37:03 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Roderick.Colenbrander@...y.com
cc:     arnd@...nel.org, benjamin.tissoires@...hat.com,
        roderick@...kai.com, arnd@...db.de, pobrn@...tonmail.com,
        djogorchock@...il.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: playstation: add LEDS_CLASS dependency

On Fri, 29 Oct 2021, Roderick.Colenbrander@...y.com wrote:

> Thanks you beat me into looking at this. Something like this got dropped through all the iterations this went through earlier this year.
> 
> I would maybe prefer to make this a hard dependency on multicolor. If 
> conditional not all devices will enable it. We have had various issues 
> already on e.g. Android were some vendors didn't set certain options.

Ah, sorry, I've seen the mail from 0day bot first before Arnd's mail, and 
the fix (adding hard dependency on LEDS_CLASS_MULTICOLOR) is already 
pushed out.

Thanks,

-- 
Jiri Kosina
SUSE Labs