linux-kernel - Re: [PATCH v2] staging: vchiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211101144853.GE2914@kadam>
Date:   Mon, 1 Nov 2021 17:48:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gaston Gonzalez <gascoar@...il.com>
Cc:     linux-staging@...ts.linux.dev, gregkh@...uxfoundation.org,
        nsaenz@...nel.org, stefan.wahren@...e.com, arnd@...db.de,
        ojaswin98@...il.com, amarjargal16@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_core: get rid of typedef

On Fri, Oct 29, 2021 at 05:00:12PM -0300, Gaston Gonzalez wrote:
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 3e50910ecba3..53a98949b294 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -74,9 +74,7 @@
>  	((fourcc) >>  8) & 0xff, \
>  	(fourcc) & 0xff
>  
> -typedef u32 BITSET_T;
> -
> -static_assert((sizeof(BITSET_T) * 8) == 32);
> +static_assert((sizeof(u32) * 8) == 32);

This assert is now pointless and should be removed.  Your patch has
already been applied so you can send a new follow on patch to do that.

Also the BITSET_* stuff should be converted to normal kernel bitfield
macros which use unsigned long pointers and set/clear/test_bit().  This
conversion is slightly more complicated so don't worry about it if you
don't want to.

regards,
dan carpenter