lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Nov 2021 18:45:19 +0000 From: Sean Christopherson <seanjc@...gle.com> To: Vitaly Kuznetsov <vkuznets@...hat.com> Cc: Maxim Levitsky <mlevitsk@...hat.com>, Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, Kieran Bingham <kbingham@...nel.org>, Jan Kiszka <jan.kiszka@...mens.com>, Andrew Jones <drjones@...hat.com>, Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>, Johannes Berg <johannes.berg@...el.com>, Wanpeng Li <wanpengli@...cent.com>, "H. Peter Anvin" <hpa@...or.com>, Jessica Yu <jeyu@...nel.org>, Jim Mattson <jmattson@...gle.com>, Joerg Roedel <joro@...tes.org>, Yang Weijiang <weijiang.yang@...el.com>, linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH v3 6/6] KVM: selftests: test KVM_GUESTDBG_BLOCKIRQ On Tue, Nov 02, 2021, Vitaly Kuznetsov wrote: > Sean Christopherson <seanjc@...gle.com> writes: > > But that mess is a red herring, the test fails with the same signature with APICv=1 > > if the STI is replaced by PUSHF+BTS+POPFD (to avoid the STI shadow). We all missed > > this key detail from Vitaly's report: > > > > SINGLE_STEP[1]: exit 8 exception 1 rip 0x402a25 (should be 0x402a27) dr6 0xffff4ff0 (should be 0xffff4ff0) > > ^^^^^^ > > > > Exit '8' is KVM_EXIT_SHUTDOWN, i.e. the arrival of the IRQ hosed the guest because > > the test doesn't invoke vm_init_descriptor_tables() to install event handlers. > > The "exception 1" shows up because the run page isn't sanitized by the test, i.e. > > it's stale data that happens to match. > > > > So I would fully expect this test to fail with AVIC=1. The problem is that > > KVM_GUESTDBG_BLOCKIRQ does absolutely nothing to handle APICv interrupts. And > > even if KVM does something to fudge that behavior in the emulated local APIC, the > > test will then fail miserably virtual IPIs (currently AVIC only). > > FWIW, the test doesn't seem to fail on my AMD EPYC system even with "avic=1" ... Huh. Assuming the IRQ is pending in the vIRR and KVM didn't screw up elsewhere, that seems like a CPU AVIC bug. #DBs have priority over IRQs, but single-step #DBs are trap-like and KVM (hopefully) isn't injecting a #DB, so a pending IRQ should be taken on the current instruction in the guest when executing VMRUN with guest.EFLAGS.IF=1,TF=1 since there will be a one-instruction delay before the single-step #DB kicks in.
Powered by blists - more mailing lists