linux-kernel - Re: Linux 5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Nov 2021 20:19:31 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 5.15

On Mon, Nov 01, 2021 at 06:44:39PM -0700, Linus Torvalds wrote:
> On Mon, Nov 1, 2021 at 6:18 PM Guenter Roeck <linux@...ck-us.net> wrote:
> >
> > Replacing "strlen(UTS_RELEASE)" with "sizeof(UTS_RELEASE) - 1" seems to do
> > the trick, at least with gcc 11.2 and v5.15. I just wonder if that would be
> > acceptable. Any idea ?
> 
> Looks sane to me.
> 
> I don't understand why gcc complains about that thing in the first
> place, much less why it only happens on m68k, but whatever...
> 
> The other - and perhaps better - option would be to just uninline
> memcpy_and_pad() entirely, move it to lib/string.c, and only have the
> declaration in <linux/string.h>.
> 
> Because the only reason to have it as an inline function is when the
> compiler can statically optimize a call site: but it's really not a
> performance-critical function to begin with, and clearly the compiler
> instead just *breaks* rather than optimize that call-site.
> 
Excellent suggestion. I'll submit a patch to do just that.

Thanks,
Guenter