linux-kernel - Re: [PATCH] HID: i2c-hid: Report wakeup events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3643a2e-8ea0-586c-62e0-4d85fd2c9a8e@redhat.com>
Date:   Tue, 2 Nov 2021 19:58:55 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Jim Broadus <jbroadus@...il.com>,
        Johnny Chuang <johnny.chuang.emc@...il.com>,
        Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] HID: i2c-hid: Report wakeup events

Hi,

On 11/2/21 19:40, Matthias Kaehlcke wrote:
> The i2c-hid driver generally supports wakeup, bit it currently
> doesn't report wakeup events to the PM subsystem. Change that.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Thanks, this looks reasonable to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> ---
> 
>  drivers/hid/i2c-hid/i2c-hid-core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 517141138b00..68d9a089e3e8 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -522,9 +522,12 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
>  
>  	i2c_hid_dbg(ihid, "input: %*ph\n", ret_size, ihid->inbuf);
>  
> -	if (test_bit(I2C_HID_STARTED, &ihid->flags))
> +	if (test_bit(I2C_HID_STARTED, &ihid->flags)) {
> +		pm_wakeup_event(&ihid->client->dev, 0);
> +
>  		hid_input_report(ihid->hid, HID_INPUT_REPORT, ihid->inbuf + 2,
>  				ret_size - 2, 1);
> +	}
>  
>  	return;
>  }
>