linux-kernel - Re: [PATCH v7 4/6] reset: Add Delta TN48M CPLD reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcWWBHDpM9+POPMUmWuGmdbyH0wCGXvqFH3znbZnTht+w@mail.gmail.com>
Date:   Tue, 2 Nov 2021 21:30:44 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Robert Marko <robert.marko@...tura.hr>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v7 4/6] reset: Add Delta TN48M CPLD reset controller

On Tue, Nov 2, 2021 at 6:57 PM Robert Marko <robert.marko@...tura.hr> wrote:
>
> Delta TN48M CPLD exposes resets for the following:
> * 88F7040 SoC
> * 88F6820 SoC
> * 98DX3265 switch MAC-s
> * 88E1680 PHY-s
> * 88E1512 PHY
> * PoE PSE controller
>
> Controller supports only self clearing resets.

...

> +#include <linux/device.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>

> +#include <linux/of.h>

I haven't found any user of this header, but mod_devicetable.h is missing.

> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/reset-controller.h>

> +#include <dt-bindings/reset/delta,tn48m-reset.h>

Shouldn't this go before linux/* as it provides more generic definitions?

...

> +#define TN48M_RESET_TIMEOUT    125000
> +#define TN48M_RESET_SLEEP      10

In which units? (both)

-- 
With Best Regards,
Andy Shevchenko