linux-kernel - Re: [PATCH v18 3/6] tpm: Handle an exception for TPM Firmware Update mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde74ac682e031a033b506f4f5505f0587e8c8d2.camel@kernel.org>
Date:   Tue, 02 Nov 2021 22:32:23 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     amirmizi6@...il.com, Eyal.Cohen@...oton.com,
        oshrialkoby85@...il.com, alexander.steffen@...ineon.com,
        robh+dt@...nel.org, mark.rutland@....com, peterhuewe@....de,
        jgg@...pe.ca, arnd@...db.de, gregkh@...uxfoundation.org,
        benoit.houyere@...com, eajames@...ux.ibm.com, joel@....id.au
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org, oshri.alkoby@...oton.com,
        tmaimon77@...il.com, gcwilson@...ibm.com, kgoldman@...ibm.com,
        Dan.Morav@...oton.com, oren.tanami@...oton.com,
        shmulik.hager@...oton.com, amir.mizinski@...oton.com,
        Borys Movchan <borysmn@...s.com>
Subject: Re: [PATCH v18 3/6] tpm: Handle an exception for TPM Firmware
 Update mode.

On Tue, 2021-11-02 at 17:20 +0200, amirmizi6@...il.com wrote:
> From: Amir Mizinski <amirmizi6@...il.com>
> 
> Add a condition to enable communication with the TPM while the TPM is in
> firmware update mode.
> In such a case if power was cut during the TPM firmware update, the driver
> should ignore the "selftest" command return code (TPM2_RC_UPGRADE or
> TPM2_RC_COMMAND_CODE) and skip the rest of the TPM initialization
> sequence.
> 
> Suggested-by: Benoit Houyere <benoit.houyere@...com>
> Signed-off-by: Amir Mizinski <amirmizi6@...il.com>

This is a half-baked handling of the FW upgrade mode.

There's another patch in progress that aims to do proper handling
for it:

https://lore.kernel.org/linux-integrity/20210930160241.9691-1-borysmn@axis.com/

I CC'd Borys for further comments/discussion.

/Jarkko