linux-kernel - Re: [PATCH] clk: ingenic: Fix bugs with divided dividers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163588847120.2993099.5234069019391601753@swboyd.mtv.corp.google.com>
Date:   Tue, 02 Nov 2021 14:27:51 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Paul Cercueil <paul@...pouillou.net>
Cc:     linux-mips@...r.kernel.org, list@...ndingux.net,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Cercueil <paul@...pouillou.net>,
        Artur Rojek <contact@...ur-rojek.eu>
Subject: Re: [PATCH] clk: ingenic: Fix bugs with divided dividers

Quoting Paul Cercueil (2021-10-01 10:20:33)
> Two fixes in one:
> 
> - In the "impose hardware constraints" block, the "logical" divider
>   value (aka. not translated to the hardware) was clamped to fit in the
>   register area, but this totally ignored the fact that the divider
>   value can itself have a fixed divider.
> 
> - The code that made sure that the divider value returned by the
>   function was a multiple of its own fixed divider could result in a
>   wrong value being calculated, because it was rounded down instead of
>   rounded up.
> 
> Fixes: 4afe2d1a6ed5 ("clk: ingenic: Allow divider value to be divided")
> Co-developed-by: Artur Rojek <contact@...ur-rojek.eu>
> Signed-off-by: Artur Rojek <contact@...ur-rojek.eu>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---

Applied to clk-next