linux-kernel - Re: [PATCH v4 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211102094335.0e7c80de@collabora.com>
Date:   Tue, 2 Nov 2021 09:43:35 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     Sean Nyekjaer <sean@...nix.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/4] mtd: rawnand: nand_bbt: hide suspend/resume
 hooks while scanning bbt

On Mon, 1 Nov 2021 09:46:23 +0100
Sean Nyekjaer <sean@...nix.com> wrote:

> On Mon, Nov 01, 2021 at 08:38:24AM +0100, Boris Brezillon wrote:
> > On Tue, 26 Oct 2021 07:55:48 +0200
> > Sean Nyekjaer <sean@...nix.com> wrote:
> >   
> > > From: Boris Brezillon <boris.brezillon@...labora.com>
> > > 
> > > The BBT scan logic use the MTD helpers before the MTD layer had a
> > > chance to initialize the device, and that leads to issues when
> > > accessing the uninitialized suspend lock. Let's temporarily set the
> > > suspend/resume hooks to NULL to skip the lock acquire/release step.
> > > 
> > > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")  
> > 
> > I think I already mentioned this Fixes tag should not be there.
> >   
> 
> No, I didn't recall that, but nevermind :)
> 
> Hmm when ('mtd: core: protect access to MTD devices while in suspend')
> is backported we want to live with the use before init of the rwsem?

It's not meant to be backported. You'll need something simpler...

> 
> /Sean