linux-kernel - Re: [PATCH bpf-next v3 2/4] libfs: support RENAME_EXCHANGE in simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7988de27-1718-60c1-ec03-9343d2cc460f@iogearbox.net>
Date:   Tue, 2 Nov 2021 11:11:02 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Miklos Szeredi <miklos@...redi.hu>,
        Lorenz Bauer <lmb@...udflare.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        network dev <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH bpf-next v3 2/4] libfs: support RENAME_EXCHANGE in
 simple_rename()

On 11/2/21 10:25 AM, Miklos Szeredi wrote:
> On Thu, 28 Oct 2021 at 11:48, Lorenz Bauer <lmb@...udflare.com> wrote:
>>
>> Allow atomic exchange via RENAME_EXCHANGE when using simple_rename.
>> This affects binderfs, ramfs, hubetlbfs and bpffs.
> 
> Ramfs and hugetlbfs are generic enough; those seem safe.
> 
> Binderfs: I have no idea what this does; binderfs_rename() should
> probably error out on RENAME_EXCHANGE for now, or an explicit ack from
> the maintainers.

Thanks for the review, Miklos! Adding Christian to Cc wrt binderfs ... full context
for all patches: https://lore.kernel.org/bpf/20211028094724.59043-1-lmb@cloudflare.com/

> Bpffs is your baby...
> 
> Thanks,
> Miklos
>