linux-kernel - [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211102021229.18501-1-wanjiabing@vivo.com>
Date:   Mon,  1 Nov 2021 22:12:27 -0400
From:   Wan Jiabing <wanjiabing@...o.com>
To:     Wolfram Sang <wsa@...nel.org>, Zhiqi Song <songzhiqi1@...wei.com>,
        Tian Tao <tiantao6@...ilicon.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Wan Jiabing <wanjiabing@...o.com>,
        Sudeep Holla <sudeep.holla@....com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     jiabing.wan@...com
Subject: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR

Fix following coccicheck warning:
./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR
and PTR_ERR on line 490.

Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
---
 drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 1a19ebad60ad..63259b3ea5ab 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -487,7 +487,7 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
 		pcc_chan = pcc_mbox_request_channel(cl, ctx->mbox_idx);
 		if (IS_ERR(pcc_chan)) {
 			dev_err(&pdev->dev, "PCC mailbox channel request failed\n");
-			return PTR_ERR(ctx->pcc_chan);
+			return PTR_ERR(pcc_chan);
 		}
 
 		ctx->pcc_chan = pcc_chan;
-- 
2.20.1