linux-kernel - Re: [PATCH] mfd: simple-mfd-i2c: Select MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b2b9e6f61107b79f93dd191c3fc2918@walle.cc>
Date:   Tue, 02 Nov 2021 13:28:51 +0100
From:   Michael Walle <michael@...le.cc>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Robert Marko <robert.marko@...tura.hr>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error

Am 2021-11-02 12:17, schrieb Lee Jones:
> On Tue, 02 Nov 2021, Robert Marko wrote:
> 
>> MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build 
>> error:
>> 
>> aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function 
>> `simple_mfd_i2c_probe':
>> drivers/mfd/simple-mfd-i2c.c:55: undefined reference to 
>> `devm_mfd_add_devices'
> 
> What is your use-case?
> 
> How are you enabling this symbol?

Mh? drivers/mfd/simple-mfd-i2c.c is using devm_mfd_add_devices which
is provided by drivers/mfd/core.c. So select MFD_CORE is clearly
missing here, no? I mean most of the MFD drivers do a "select MFD_CORE".

-michael