linux-kernel - Re: [GIT PULL] SPI updates for v5.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whxDHD7PFLdtS_am8ta5uqyBnjhkQTcRLtPN6-3K+TuRg@mail.gmail.com>
Date:   Mon, 1 Nov 2021 19:16:22 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-spi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SPI updates for v5.16

On Mon, Nov 1, 2021 at 8:21 AM Mark Brown <broonie@...nel.org> wrote:
>
> This is quite a quiet release for SPI, there's been a bit of cleanup to
> the core from Uwe but nothing functionality wise.

You continue to have these completely invalid merge commits that don't
actually say what they merge and *WHY*:

These four have one single line of "explanation":

  531558b56be5 Merge branch 'spi-5.15' into spi-5.16
  5fe7bd5a37ff Merge branch 'spi-5.15' into spi-5.16
  66ae258ccf40 Merge branch 'spi-5.15' into spi-5.16
  becbca18ae8f Merge existing fixes from spi/for-5.15

which is not good.

And the ones that aren't one-liners have pointless other garbage in
them in addition to the actual useful information. Things like

    Hello,
   ...
    Best regards
    Uwe
   ...
    base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896
    --
    2.30.2

are just complete noise that seems to indicate that you automate your
merges with garbage, instead of actually editing them and making them
be meaningful.

STOP DOING THIS.

Seriously. The commit messages for merges are important. They should
explain what the merge dows and why it exists, but it also shouldn't
contain random garbage from the email of the person who sent you a
pull request.

                  Linus