lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Nov 2021 21:48:10 +0800 From: Yafang Shao <laoar.shao@...il.com> To: Petr Mladek <pmladek@...e.com> Cc: Steven Rostedt <rostedt@...dmis.org>, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>, Peter Zijlstra <peterz@...radead.org>, Al Viro <viro@...iv.linux.org.uk>, Valentin Schneider <valentin.schneider@....com>, Qiang Zhang <qiang.zhang@...driver.com>, robdclark <robdclark@...omium.org>, christian <christian@...uner.io>, Dietmar Eggemann <dietmar.eggemann@....com>, Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, dennis.dalessandro@...nelisnetworks.com, mike.marciniszyn@...nelisnetworks.com, dledford@...hat.com, jgg@...pe.ca, linux-rdma@...r.kernel.org, netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, "linux-perf-use." <linux-perf-users@...r.kernel.org>, linux-fsdevel@...r.kernel.org, Linux MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, kernel test robot <oliver.sang@...el.com>, kbuild test robot <lkp@...el.com> Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 On Tue, Nov 2, 2021 at 3:56 PM Petr Mladek <pmladek@...e.com> wrote: > > On Tue 2021-11-02 09:26:35, Yafang Shao wrote: > > On Tue, Nov 2, 2021 at 9:18 AM Steven Rostedt <rostedt@...dmis.org> wrote: > > > On Tue, 2 Nov 2021 09:09:50 +0800 > > > Yafang Shao <laoar.shao@...il.com> wrote: > > > > Now we only care about kthread, so we can put the pointer into a > > > > kthread specific struct. > > > > For example in the struct kthread, or in kthread->data (which may > > > > conflict with workqueue). > > > > > > No, add a new field to the structure. "full_name" or something like that. > > > I'm guessing it should be NULL if the name fits in TASK_COMM_LEN and > > > allocated if the name had to be truncated. > > > > > > Do not overload data with this. That will just make things confusing. > > > There's not that many kthreads, where an addition of an 8 byte pointer is > > > going to cause issues. > > > > Sure, I will add a new field named "full_name", which only be > > allocated if the kthread's comm is truncated. > > The plan looks good to me. > > One more thing. It should obsolete the workqueue-specific solution. > It would be great to clean up the workqueue code as the next step. > Agreed. The worker comm can be replaced by the new kthread full_name. I will do it in the next step. -- Thanks Yafang
Powered by blists - more mailing lists