linux-kernel - Re: [GIT PULL] Networking for 5.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211102071051.15a89ab6@kicinski-fedora-PC1C0HJN>
Date:   Tue, 2 Nov 2021 07:10:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        keescook@...omium.org, kvalo@...eaurora.org,
        miriam.rachel.korenblit@...el.com
Subject: Re: [GIT PULL] Networking for 5.16

On Tue, 2 Nov 2021 06:20:35 -0700 Linus Torvalds wrote:
> On Mon, Nov 1, 2021 at 10:43 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-for-5.16  
> 
> I get quite a lot of
> 
>     ./scripts/pahole-flags.sh: line 7: return: can only `return' from
> a function or sourced script
> 
> with this. Why didn't anybopdy else notice? It seems entirely bogus
> and presumably happens everywhere else too.
> 
> It's shell script. You don't "return" from it. You "exit" from it.
> 
> Grr.

Sorry about that. 

Looks like the patch was merged on Friday, presumably nobody tried 
to build -next without pahole installed on their system since.

Let me correct for that by sending the PR on Tue next merge window.
Hopefully an extra day will be enough for someone to catch silly 
mistakes like this. I had to do a last minute TCP revert as well,
so yeah, seems like Monday was a little rushed on my side.