linux-kernel - Re: [PATCH V2 4/4] crypto: ccp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Nov 2021 08:21:48 -0600
From:   Peter Gonda <pgonda@...gle.com>
To:     Tom Lendacky <Thomas.Lendacky@....com>
Cc:     David Rientjes <rientjes@...gle.com>,
        Marc Orr <marcorr@...gle.com>,
        Brijesh Singh <brijesh.singh@....com>,
        Joerg Roedel <jroedel@...e.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        John Allen <john.allen@....com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 4/4] crypto: ccp - Add SEV_INIT_EX support

On Mon, Nov 1, 2021 at 2:02 PM Tom Lendacky <thomas.lendacky@....com> wrote:
>
> On 11/1/21 2:18 PM, Peter Gonda wrote:
> > On Mon, Nov 1, 2021 at 12:41 PM Tom Lendacky <thomas.lendacky@....com> wrote:
> >> On 11/1/21 12:21 PM, Peter Gonda wrote:
>
> ...
>
> >>> +
> >>> +     fp = filp_open(init_ex_path, O_RDONLY, 0);
> >>> +     if (IS_ERR(fp)) {
> >>> +             const int ret = PTR_ERR(fp);
> >>
> >> I don't think you need the "const" here.
> >
> > Sounds good, removed. I normally default to consting a variable if I
> > don't expect/want it to change. What guidance should I be following
> > here?
>
> Heh, I don't know... I guess since its in such a short scope it just read
> easier to me.  But, you're correct, const is appropriate here, so I guess
> feel free to leave it in if you want.

Thanks! I'll remove it here to be more consistent with this file.

>
> >
> >>
>
> ...
>
> >> "SEV: write successful to NV file\n"
> >
> > Updated all messages. Should have noted the "SEV: .." format.
>
> It's not like we were very consistent originally, but it would be nice to
> have the new messages start to maintain a consistency.
>
> Thanks,
> Tom
>
> >