linux-kernel - Re: [PATCH v5 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Nov 2021 16:37:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Daniel Scally <djrscally@...il.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Kate Hsuan <hpa@...hat.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v5 00/11] Add support for X86/ACPI camera sensor/PMIC
 setup with clk and regulator platform data

On Tue, Nov 2, 2021 at 11:49 AM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Here is v5 of my patch-set adding support for camera sensor connected to a
> TPS68470 PMIC on x86/ACPI devices.

No showstoppers observed, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> I'm quite happy with how this works now, so from my pov this is the final
> version of the device-instantiation deferral code / approach.
>
> ###
>
> The clk and regulator frameworks expect clk/regulator consumer-devices
> to have info about the consumed clks/regulators described in the device's
> fw_node, but on ACPI this info is missing.
>
> This series worksaround this by providing platform_data with the info to
> the TPS68470 clk/regulator MFD cells.
>
> Patches 1 - 2 deal with a probe-ordering problem this introduces,
> since the lookups are only registered when the provider-driver binds,
> trying to get these clks/regulators before then results in a -ENOENT
> error for clks and a dummy regulator for regulators. See the patches
> for more details.
>
> Patch 3 adds a header file which adds tps68470_clk_platform_data and
> tps68470_regulator_platform_data structs. The futher patches depend on
> this new header file.
>
> Patch 4 + 5 add the TPS68470 clk and regulator drivers
>
> Patches 6 - 11 Modify the INT3472 driver which instantiates the MFD cells to
> provide the necessary platform-data.


-- 
With Best Regards,
Andy Shevchenko