linux-kernel - Re: [PATCH v1 1/5] tty: rpmsg: Assign returned id to a local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdBd0LORz+DX-1QUaXfEiC+iiev4dY4-mPG+rsUxcupyw@mail.gmail.com>
Date:   Tue, 2 Nov 2021 16:40:39 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/5] tty: rpmsg: Assign returned id to a local variable

On Tue, Nov 2, 2021 at 3:21 PM Arnaud POULIQUEN
<arnaud.pouliquen@...s.st.com> wrote:
> On 10/25/21 3:51 PM, Andy Shevchenko wrote:

...

> > +     cport->id = err;
>
> Set the cport->id to the err variable on success doesn't seem completely clean
> to me either.

I totally agree with you, that's why the
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=408a507996e4
 changed it.

-- 
With Best Regards,
Andy Shevchenko