linux-kernel - Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com>
Date:   Tue, 2 Nov 2021 10:48:14 +0800
From:   He Ying <heying24@...wei.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>, <mripard@...nel.org>,
        <wens@...e.org>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <jernej.skrabec@...il.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-sunxi@...ts.linux.dev>
Subject: Re: [PATCH] drm: Grab reference of connector before return connector
 from sun4i_tcon_get_connector


在 2021/11/1 21:02, Jani Nikula 写道:
> On Mon, 01 Nov 2021, He Ying <heying24@...wei.com> wrote:
>>  From the comments of drm_for_each_connector_iter(), we know
>> that "connector is only valid within the list body, if you
>> want to use connector after calling drm_connector_list_iter_end()
>> then you need to grab your own reference first using
>> drm_connector_get()". So fix the wrong use of connector
>> according to the comments and then call drm_connector_put()
>> after using connector finishes.
>>
>> Signed-off-by: He Ying <heying24@...wei.com>
> Please use "drm/sun4i:" subject prefix for sun4i patches.

OK. I'll send a V2 later. By the way, may I have your suggestions about

this patch's content.