| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YYFsJ+J9m7QBGpmB@robh.at.kernel.org>
Date: Tue, 2 Nov 2021 11:49:43 -0500
From: Rob Herring <robh@...nel.org>
To: YC Hung <yc.hung@...iatek.com>
Cc: broonie@...nel.org, tiwai@...e.com, matthias.bgg@...il.com,
alsa-devel@...a-project.org, linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, daniel.baluta@....com,
trevor.wu@...iatek.com, allen-kh.cheng@...iatek.com,
angelogioacchino.delregno@...labora.com
Subject: Re: [PATCH v4 2/2] dt-bindings: dsp: mediatek: Add mt8195 DSP
binding support
On Thu, Oct 28, 2021 at 09:57:37PM +0800, YC Hung wrote:
> This describes the mt8195 DSP device tree node.
>
> Signed-off-by: YC Hung <yc.hung@...iatek.com>
> ---
> .../bindings/dsp/mtk,mt8195-dsp.yaml | 139 ++++++++++++++++++
> 1 file changed, 139 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
>
> diff --git a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> new file mode 100644
> index 000000000000..f113f71ca094
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> @@ -0,0 +1,139 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/mtk,mt8195-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek mt8195 DSP core
> +
> +maintainers:
> + - YC Hung <yc.hung@...iatek.com>
> +
> +description: |
> + Some boards from mt8195 contain a DSP core used for
> + advanced pre- and post- audio processing.
> +properties:
> + compatible:
> + const: mediatek,mt8195-dsp
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + maxItems: 2
Need to define what each entry is and the names for them.
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + maxItems: 1
Need to define the name. Though -names with 1 entry is not that useful.
> +
> + clocks:
> + items:
> + - description: mux for audio dsp clock
> + - description: 26M clock
> + - description: mux for audio dsp local bus
> + - description: default audio dsp local bus clock source
> + - description: clock gate for audio dsp clock
> + - description: mux for audio dsp access external bus
> +
> + clock-names:
> + items:
> + - const: adsp_sel
> + - const: clk26m_ck
> + - const: audio_local_bus
> + - const: mainpll_d7_d2
> + - const: scp_adsp_audiodsp
> + - const: audio_h
> +
> + power-domains:
> + maxItems: 1
> +
> + mboxes:
> + maxItems: 2
> +
> + mbox-names:
> + description:
> + Specifies the mailboxes used to communicate with audio DSP
> + items:
> + - const: mbox0
> + - const: mbox1
Is there not a specific function for each mailbox? You already have an
index implicitly.
> +
> + memory-region:
> + description:
> + phandle to a node describing reserved memory (System RAM memory)
> + used by DSP (see bindings/reserved-memory/reserved-memory.txt)
> + maxItems: 2
1 phandle or 2? If 2, what is each one for?
> +
> + sound:
> + description:
> + Sound subnode includes ASoC platform, DPTx codec node, and
> + HDMI codec node.
> +
> + type: object
additionalProperties: false
Though why do you need a child node here in the first place?
> +
> + properties:
> + mediatek,platform:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of MT8195 ASoC platform.
> +
> + mediatek,dptx-codec:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of MT8195 Display Port Tx codec node.
> +
> + mediatek,hdmi-codec:
> + $ref: "/schemas/types.yaml#/definitions/phandle"
> + description: The phandle of MT8195 HDMI codec node.
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - interrupt-names
> + - clocks
> + - clock-names
> + - memory-region
> + - power-domains
> + - mbox-names
> + - mboxes
> + - sound
> +
> +
Extra blank line.
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + adsp: adsp@...03000 {
dsp@...
> + compatible = "mediatek,mt8195-dsp";
> + reg = <0x10803000 0x1000>,
> + <0x10840000 0x40000>;
> + reg-names = "cfg", "sram";
> + interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "wdt";
> + clocks = <&topckgen 10>, //CLK_TOP_ADSP
> + <&clk26m>,
> + <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS
> + <&topckgen 136>, //CLK_TOP_MAINPLL_D7_D2
> + <&scp_adsp 0>, //CLK_SCP_ADSP_AUDIODSP
> + <&topckgen 34>; //CLK_TOP_AUDIO_H
> + clock-names = "adsp_sel",
> + "clk26m_ck",
> + "audio_local_bus",
> + "mainpll_d7_d2",
> + "scp_adsp_audiodsp",
> + "audio_h";
> + memory-region = <&adsp_dma_mem_reserved>,
> + <&adsp_mem_reserved>;
> + power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> + mbox-names = "mbox0", "mbox1";
> + mboxes = <&adsp_mailbox 0>, <&adsp_mailbox 1>;
> + status = "disabled";
Don't disable your example. Drop status.
> + sound {
> + mediatek,dptx-codec = <&dp_tx>;
> + mediatek,hdmi-codec = <&hdmi0>;
> + mediatek,platform = <&afe>;
> + };
> + };
> --
> 2.18.0
>
>
Powered by blists - more mailing lists