linux-kernel - [PATCH] staging: rtl8723bs: Fix the style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <618175c4.1c69fb81.bff5d.9cb8@mx.google.com>
Date:   Wed,  3 Nov 2021 01:30:17 +0800
From:   hoshinomorimorimo@...il.com
To:     gregkh@...uxfoundation.org, fabioaiuto83@...il.com,
        ross.schm.dev@...il.com
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Hoshinomori-Owari <hoshinomorimorimo@...il.com>
Subject: [PATCH] staging: rtl8723bs: Fix the style problem

From: Hoshinomori-Owari <hoshinomorimorimo@...il.com>

Fix block comment at
rtw_io.c:8:
rtw_io.c:139:
rtw_io.c:154:

Remove not useful filename at
rtw_io.c:9:

Add a blank line after declarations
rtw_io.c:147:

Issue found by checkpatch.pl

Signed-off-by: Hoshinomori-Owari <hoshinomorimorimo@...il.com>
---
 drivers/staging/rtl8723bs/core/rtw_io.c | 56 +++++++++++++------------
 1 file changed, 29 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
index 4d3c30ec93b5..6c46c6e295d5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -4,26 +4,27 @@
  * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
  *
  ******************************************************************************/
-/*
-
-The purpose of rtw_io.c
-
-a. provides the API
-
-b. provides the protocol engine
-
-c. provides the software interface between caller and the hardware interface
-
 
-Compiler Flag Option:
-
-1. CONFIG_SDIO_HCI:
-    a. USE_SYNC_IRP:  Only sync operations are provided.
-    b. USE_ASYNC_IRP:Both sync/async operations are provided.
-
-jackson@...ltek.com.tw
-
-*/
+/*
+ *
+ *Purpose:
+ *
+ *	a. provides the API
+ *
+ *	b. provides the protocol engine
+ *
+ *	c. provides the software interface between caller and the hardware interface
+ *
+ *
+ *Compiler Flag Option:
+ *
+ *1. CONFIG_SDIO_HCI:
+ *	a. USE_SYNC_IRP:  Only sync operations are provided.
+ *	b. USE_ASYNC_IRP:Both sync/async operations are provided.
+ *
+ *jackson@...ltek.com.tw
+ *
+ */
 
 #include <drv_types.h>
 #include <rtw_debug.h>
@@ -135,24 +136,25 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt
 	return _SUCCESS;
 }
 
-/*
-* Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR
-* @return true:
-* @return false:
-*/
+/**
+ * Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR
+ * @return true:
+ * @return false:
+ */
 int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj)
 {
 	int ret = false;
 	int value = atomic_inc_return(&dvobj->continual_io_error);
+
 	if (value > MAX_CONTINUAL_IO_ERR)
 		ret = true;
 
 	return ret;
 }
 
-/*
-* Set the continual_io_error of this @param dvobjprive to 0
-*/
+/**
+ * Set the continual_io_error of this @param dvobjprive to 0
+ */
 void rtw_reset_continual_io_error(struct dvobj_priv *dvobj)
 {
 	atomic_set(&dvobj->continual_io_error, 0);
-- 
2.31.1