linux-kernel - Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26baa410-7df7-901e-00e2-0b3cca3491c8@nvidia.com>
Date:   Tue, 2 Nov 2021 22:07:28 -0700
From:   Dipen Patel <dipenp@...dia.com>
To:     Randy Dunlap <rdunlap@...radead.org>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <linux-kernel@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linus.walleij@...aro.org>, <bgolaszewski@...libre.com>,
        <warthog618@...il.com>, <devicetree@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver

Hi,


On 10/1/21 4:47 PM, Randy Dunlap wrote:
> Hi,
>
> On 9/30/21 4:26 PM, Dipen Patel wrote:
>> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
>> index eb339526f141..57c97034d187 100644
>> --- a/drivers/hte/Kconfig
>> +++ b/drivers/hte/Kconfig
>> @@ -38,4 +38,13 @@ config HTE_TEGRA194_IRQ_TEST
>>         The NVIDIA Tegra194 GTE IRQ test driver demonstrates HTE subsystem
>>         usage for the LIC IRQ hardware timestamp.
>>   +config HTE_TEGRA194_GPIO_TEST
>> +        tristate "NVIDIA Tegra194 HTE GPIO Test"
>> +        depends on HTE_TEGRA194
>> +        help
>> +      The NVIDIA Tegra194 GTE GPIO test driver demonstrates how to use HTE
>
>                                                                 to use the HTE
>
>> +      subsystem indirectly through gpiolib API calls for GPIO line for the
>
>                                                               lines
>
>> +      hardware assisted timestamping.
>
>       hardware-assisted
>
>> +
>>   endif
>
> Also:
>
> Please follow coding-style for Kconfig files:
>
> (from Documentation/process/coding-style.rst, section 10):
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
> Some of the lines above are indented with spaces instead of one tab.
>
I will double check this. From the RFCv1 comments, I did correct formatting according

to above coding style i.e. everything 1 tab except help which is 1 tab + 2 spaces.

>
> thanks.