linux-kernel - [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  3 Nov 2021 05:56:22 +0000
From:   cgel.zte@...il.com
To:     hca@...ux.ibm.com
Cc:     gor@...ux.ibm.com, borntraeger@...ibm.com, agordeev@...ux.ibm.com,
        svens@...ux.ibm.com, egorenar@...ux.ibm.com, geert@...ux-m68k.org,
        zhang.mingyu@....com.cn, frankja@...ux.ibm.com,
        ebiederm@...ssion.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.

From: Zhang Mingyu <zhang.mingyu@....com.cn>

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Zhang Mingyu <zhang.mingyu@....com.cn>
---
 arch/s390/mm/fault.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
index d30f5986fa85..48a0231158c9 100644
--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -824,8 +824,7 @@ void do_secure_storage_access(struct pt_regs *regs)
 			break;
 		rc = arch_make_page_accessible(page);
 		put_page(page);
-		if (rc)
-			BUG();
+		BUG_ON(rc);
 		break;
 	case GMAP_FAULT:
 	default:
-- 
2.25.1