linux-kernel - Re: [PATCH] net/mlx5:using swap() instead of tmp variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb52fc1b-4e95-bc5e-6aa9-82b9b35967cf@nvidia.com>
Date:   Wed, 3 Nov 2021 08:57:15 +0200
From:   Roi Dayan <roid@...dia.com>
To:     Yihao Han <hanyihao@...o.com>, Saeed Mahameed <saeedm@...dia.com>,
        "Leon Romanovsky" <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>, Paul Blakey <paulb@...dia.com>,
        Oz Shlomo <ozsh@...dia.com>,
        Ariel Levkovich <lariel@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>, Chris Mi <cmi@...dia.com>,
        <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <kernel@...o.com>
Subject: Re: [PATCH] net/mlx5:using swap() instead of tmp variable



On 2021-11-03 8:21 AM, Yihao Han wrote:
> swap() was used instead of the tmp variable to swap values
> 
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> index 740cd6f088b8..d4b4f32603f2 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> @@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
>   	struct mlx5_ct_tuple rev_tuple = entry->tuple;
>   	struct mlx5_ct_counter *shared_counter;
>   	struct mlx5_ct_entry *rev_entry;
> -	__be16 tmp_port;
>   
>   	/* get the reversed tuple */
> -	tmp_port = rev_tuple.port.src;
> -	rev_tuple.port.src = rev_tuple.port.dst;
> -	rev_tuple.port.dst = tmp_port;
> +	swap(rev_tuple.port.src, rev_tuple.port.dst);
>   
>   	if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
>   		__be32 tmp_addr = rev_tuple.ip.src_v4;
> 


just small comment on the title.
missing a space in the commit title after the colon.
I also think the prefix should be "net/mlx5e: CT, ..."

Reviewed-by: Roi Dayan <roid@...dia.com>