lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <06F02AA4-57B3-48C8-8366-DEE672C510FA@holtmann.org> Date: Wed, 3 Nov 2021 09:31:03 +0100 From: Marcel Holtmann <marcel@...tmann.org> To: tjiang@...eaurora.org Cc: Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-bluetooth <linux-bluetooth@...r.kernel.org>, MSM <linux-arm-msm@...r.kernel.org>, Balakrishna Godavarthi <bgodavar@...eaurora.org>, c-hbandi@...eaurora.org, Hemantg <hemantg@...eaurora.org>, Matthias Kaehlcke <mka@...omium.org>, Rocky Liao <rjliao@...eaurora.org>, zijuhu@...eaurora.org Subject: Re: [PATCH v1] Bluetooth: btusb: correct nvm file name for WCN6855 btsoc Hi Tim, > As we name nvm file by using big-endian for boardID, so align host with it. > > Signed-off-by: Tim Jiang <tjiang@...eaurora.org> > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 46d892bbde62..572d64524cf3 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3072,7 +3072,7 @@ static void btusb_generate_qca_nvm_name(char *fwname, size_t max_size, > u16 flag = le16_to_cpu(ver->flag); > > if (((flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) { > - u16 board_id = le16_to_cpu(ver->board_id); > + u16 board_id = be16_to_cpu(ver->board_id); > const char *variant; this change is not matching the commit description. It makes no sense. This is about your ver data structure and not your filename. So inside your ver struct you have a mix of little-endian and bit-endian fields? Regards Marcel
Powered by blists - more mailing lists