linux-kernel - Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEg-Je_3n9vFpP-vmVzkbDZY154g3xOK5JqPN7r9kGXJ1Zp0+w@mail.gmail.com>
Date:   Wed, 3 Nov 2021 07:05:32 -0400
From:   Neal Gompa <ngompa13@...il.com>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pekka Paalanen <pekka.paalanen@...labora.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Peter Robinson <pbrobinson@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Michel Dänzer <michel@...nzer.net>
Subject: Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the
 DRM subsystem

On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas
<javierm@...hat.com> wrote:
>
> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
> but the exported vgacon_text_force() symbol is only used by DRM drivers.
>
> It makes much more sense for the parameter logic to be in the subsystem
> of the drivers that are making use of it. Let's move that to DRM.
>
> Suggested-by: Daniel Vetter <daniel.vetter@...ll.ch>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---

Please no, I'd much rather have a better, more meaningful option
instead of "nomodeset". If anything, I would like this option to
eventually do nothing and replace it with a better named option that's
namespaced by drm on the command-line. That was part of the feedback I
gave in the original patch set, and I still stand by that.


-- 
真実はいつも一つ！/ Always, there's only one truth!