linux-kernel - Re: [PATCH] fs/super.c: defer more work after super_block is off of the super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YYJ9NxENlOHAjKW4@bombadil.infradead.org>
Date:   Wed, 3 Nov 2021 05:14:47 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     viro@...iv.linux.org.uk
Cc:     neilb@...e.de, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/super.c: defer more work after super_block is off of
 the super_blocks list

On Fri, Oct 22, 2021 at 04:28:46PM -0700, Luis Chamberlain wrote:
> Once it is off the super_blocks list we don't really need to hold the
> sb_lock anymore, we can defer the rest of the work. This reduces a few
> uneeded operations from contention from the sb_lock.
> 
> This is a minor optimization found through code inspection. If the
> sb_lock is not needed, no need for contention to wait while we free
> items. While at it, add a bit of documentation about the extent to
> which the sb_lock is used.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>

*poke*

  Luis