[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YYKZkz3EFfdENhoZ@smile.fi.intel.com>
Date: Wed, 3 Nov 2021 16:15:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonas Dreßler <verdre@...d.nl>
Cc: Brian Norris <briannorris@...omium.org>,
Amitkumar Karwar <amitkarwar@...il.com>,
Ganapathi Bhat <ganapathi017@...il.com>,
Xinming Hu <huxinming820@...il.com>,
Kalle Valo <kvalo@...eaurora.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Tsuchiya Yuto <kitakar@...il.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Maximilian Luz <luzmaximilian@...il.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH] mwifiex: Add quirk to disable deep sleep with certain
hardware revision
On Wed, Nov 03, 2021 at 02:37:53PM +0100, Jonas Dreßler wrote:
> On 11/3/21 13:25, Jonas Dreßler wrote:
...
> > > > + if (strncmp(ver_ext->version_str, "ChipRev:20, BB:9b(10.00), RF:40(21)", 128) == 0) {
> > >
> > > Rather than memorize the 128-size array here, maybe use
> > > sizeof(ver_ext->version_str) ?
> >
> > Sounds like a good idea, yeah.
>
> Nevermind, the reason I did this was for consistency in the
> function, right underneath in the same function it also assumes
> a fixed size of 128 characters, so I'd rather use the same
> length.
>
> > memcpy(version_ext->version_str, ver_ext->version_str,
> > sizeof(char) * 128);
Besides sizeof(char)...
> > memcpy(priv->version_str, ver_ext->version_str, 128);
>
> Might be a good idea to #define it as MWIFIEX_VERSION_STR_LENGTH
> in fw.h though...
...I think you simply need a precursor patch that changes this
to sizeof() / #define approach.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists