linux-kernel - Re: [PATCH] media: i2c: ov7740: implement get_mbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YYKZ8emK6JrE4pyr@paasikivi.fi.intel.com>
Date:   Wed, 3 Nov 2021 16:17:21 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Eugen.Hristev@...rochip.com
Cc:     akinobu.mita@...il.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, jacopo@...ndi.org
Subject: Re: [PATCH] media: i2c: ov7740: implement get_mbus_config

On Wed, Nov 03, 2021 at 12:39:52PM +0000, Eugen.Hristev@...rochip.com wrote:
> On 11/3/21 10:08 AM, Sakari Ailus wrote:
> > Hi Eugen,
> > 
> > Thanks for the patch.
> > 
> > On Tue, Nov 02, 2021 at 05:30:08PM +0200, Eugen Hristev wrote:
> >> Implement the get_mbus_config callback.
> >> ov7740 is a parallel sensor, and according to datasheet, the register
> >> REG12 controls the CCIR656 mode. This register is written to 0 in yuyv mode.
> >> According to REG12[5] , CCIR656 mode, the behavior is:
> >> CCIR656: disabled
> >> REG28 controls the polarity of the signals. This register is unused.
> >> The default behavior is then:
> >> HSYNC polarity : positive
> >> VSYNC polarity : positive
> >> HREF polarity: positive
> >>
> > 
> > Doesn't the receiver driver get this information from DT?
> > 
> 
> Hi Sakari,
> 
> This patch comes as a result of my discussions with Jacopo, he advised 
> to get mbus configuration via the get_mbus_config . I agree that this 
> information can be taken from DT as you said.
> In the end , my understanding is that get_mbus_config should be used 
> only for runtime configuration which can change.
> Thus, if all this information is static, then, I will proceed with 
> obtaining it from DT, and you can disregard this patch, as it is not useful.

Yes, please.

Getting this from DT is preferred if no dynamic configuration is needed.

-- 
Sakari Ailus