linux-kernel - Re: [PATCH bpf-next v4 1/2] bpf: support BPF_PROG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9ed289892e1448c69f58f0268c395167@huawei.com>
Date:   Wed, 3 Nov 2021 02:25:15 +0000
From:   "zhudi (E)" <zhudi2@...wei.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Yonghong Song <yhs@...com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Jakub Sitnicki <jakub@...udflare.com>,
        bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v4 1/2] bpf: support BPF_PROG_QUERY for progs
 attached to sockmap

> On Tue, Nov 2, 2021 at 1:11 PM Yonghong Song <yhs@...com> wrote:
> > >
> > > -static int sock_map_prog_update(struct bpf_map *map, struct bpf_prog
> *prog,
> > > -                             struct bpf_prog *old, u32 which)
> > > +static int sock_map_prog_lookup(struct bpf_map *map, struct bpf_prog
> **pprog[],
> >
> > Can we just change "**pprog[]" to "***pprog"? In the code, you really
> > just pass the address of the decl "struct bpf_prog **pprog;" to the
> > function.
> 
> Di,
> 
> this feedback was given twice already.
> You also didn't address several other points from the earlier reviews.
> Please do not resubmit until you address all points.

Maybe i miss something...
I will recheck the review comments.