linux-kernel - Re: [GIT PULL] Thermal control updates for v5.16-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52e3ba9a-6324-5d62-8327-048dd03dfc5d@linaro.org>
Date:   Wed, 3 Nov 2021 16:20:00 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Thermal control updates for v5.16-rc1

On 03/11/2021 16:03, Linus Torvalds wrote:
> On Wed, Nov 3, 2021 at 12:53 AM Daniel Lezcano
> <daniel.lezcano@...aro.org> wrote:
>>
>> Is the platform with 19 thermal zones and default thermal policy set to
>> userspace governor ?
> 
> I think it has 11 thermal zones judging by
> /sys/class/thermal/thermal_zone* going from 0 to 10.
> 
> And the kernel default seems to be
> 
>    CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE=y
> 
> but presumably this is F34 then setting it to 'userspace' (the kernel
> config comes from the F34 one too, although it's been tweaked for the
> machine).
> 
> I suspect I could just turn off THERMAL_GOV_USER_SPACE and get rid of
> the message, that's not the issue.
> 
> The issue is "why is the kernel spewing pointlessly the same message
> over and over again?"

Yes, I agree and I will provide a patch to convert it to pr_warn_once
but having 19 messages sounds like the policy was set several times and
that is surprising.

This is why I asked about the configuration because the message should
appear when one thermal zone is changing the policy to 'user_space' and
that happens once per thermal zone, logically.

I'll send a fix for that and try to figure out what f34 is doing with
the thermal governors.

Thanks

  -- Daniel

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog