linux-kernel - [PATCH] lib/bitmap: drop unneeded small_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211103163005.991003-1-yury.norov@gmail.com>
Date:   Wed,  3 Nov 2021 09:30:05 -0700
From:   Yury Norov <yury.norov@...il.com>
To:     linux-kernel@...r.kernel.org, Yury Norov <yury.norov@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: [PATCH] lib/bitmap: drop unneeded small_const_nbits() calls

Since recently, find_bit() functions have their own optimizations for a
small_const_nbits() case. Therefore drop this check in relevant bitmap
functions.

Signed-off-by: Yury Norov <yury.norov@...il.com>
---
 include/linux/bitmap.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 7dba0847510c..f4b47cc185fa 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -382,17 +382,11 @@ static inline int bitmap_subset(const unsigned long *src1,
 
 static inline bool bitmap_empty(const unsigned long *src, unsigned nbits)
 {
-	if (small_const_nbits(nbits))
-		return ! (*src & BITMAP_LAST_WORD_MASK(nbits));
-
 	return find_first_bit(src, nbits) == nbits;
 }
 
 static inline bool bitmap_full(const unsigned long *src, unsigned int nbits)
 {
-	if (small_const_nbits(nbits))
-		return ! (~(*src) & BITMAP_LAST_WORD_MASK(nbits));
-
 	return find_first_zero_bit(src, nbits) == nbits;
 }
 
-- 
2.30.2