linux-kernel - Re: [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c22e305e-cf28-9dfe-8354-9d71ee643faf@canonical.com>
Date:   Wed, 3 Nov 2021 17:49:32 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: Fix silly typo resulting
 in checkpatch warning

On 03/11/2021 17:48, Will Deacon wrote:
> Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm
> arch timer on arm64") changed the rating of the MCT clockevents device
> to be lower than the Arm architected timer and, in the process, replaced
> a semicolon with a comma thanks to a silly copy-paste error.
> 
> Put the semicolon back so that the code looks more idiomatic and resolve
> the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
> 
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Signed-off-by: Will Deacon <will@...nel.org>
> ---
> 
> Although this doesn't have a functional impact and I'd normally not pay
> too much attention to checkpatch warnings, the code is pretty weird as-is
> and I didn't intend for that comma to be there!
> 
>  drivers/clocksource/exynos_mct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>


Best regards,
Krzysztof