linux-kernel - Re: [PATCH 1/5] drivers/mfd: sensehat: Raspberry Pi Sense HAT core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ab3e853d445ed8f7c2166df620dd67bff95454d.camel@redhat.com>
Date:   Wed, 03 Nov 2021 17:53:40 +0100
From:   nsaenzju@...hat.com
To:     Matthias Brugger <mbrugger@...e.com>,
        Charles Mirabile <cmirabil@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Lee Jones <lee.jones@...aro.org>,
        Serge Schneider <serge@...pberrypi.org>,
        Stefan Wahren <stefan.wahren@...e.com>,
        linux-rpi-kernel@...ts.infradead.org, fedora-rpi@...glegroups.com,
        Mwesigwa Guma <mguma@...hat.com>,
        Joel Savitz <jsavitz@...hat.com>
Subject: Re: [PATCH 1/5] drivers/mfd: sensehat: Raspberry Pi Sense HAT core
 driver

On Wed, 2021-11-03 at 17:33 +0100, Matthias Brugger wrote:
> > +
> > +	sensehat->joystick.pdev = sensehat_client_dev_register(sensehat,
> > +							       "sensehat-joystick");
> 
> Why don't you use devm_mfd_add_devices function together with mfd_cell?

To complete Matthias' comment, why not use simple-mfd-i2c?

-- 
Nicolás Sáenz