linux-kernel - Re: [PATCH] ACPI: EC: fix error "do not initialise statics to false"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gS5Mo3REP-Y14gxUWge3avdiANHXi51R+mwz+EOBi_1w@mail.gmail.com>
Date:   Wed, 3 Nov 2021 19:18:47 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     wangzhitong <wangzhitong@...ontech.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: EC: fix error "do not initialise statics to false"

On Wed, Nov 3, 2021 at 6:52 AM wangzhitong <wangzhitong@...ontech.com> wrote:
>
> this patch fixes below Errors reported by checkpatch
> ERROR: do not initialise statics to false
> +static bool ec_freeze_events __read_mostly = false;
> ERROR: do not initialise statics to false
> +static bool boot_ec_is_ecdt = false;
>
> Signed-off-by: wangzhitong <wangzhitong@...ontech.com>
> ---
>  drivers/acpi/ec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 04ce2b96c3da..1255649a4da9 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -133,7 +133,7 @@ static unsigned int ec_storm_threshold  __read_mostly = 8;
>  module_param(ec_storm_threshold, uint, 0644);
>  MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
>
> -static bool ec_freeze_events __read_mostly = false;
> +static bool ec_freeze_events __read_mostly;
>  module_param(ec_freeze_events, bool, 0644);
>  MODULE_PARM_DESC(ec_freeze_events, "Disabling event handling during suspend/resume");
>
> @@ -177,7 +177,7 @@ struct acpi_ec *first_ec;
>  EXPORT_SYMBOL(first_ec);
>
>  static struct acpi_ec *boot_ec;
> -static bool boot_ec_is_ecdt = false;
> +static bool boot_ec_is_ecdt;
>  static struct workqueue_struct *ec_wq;
>  static struct workqueue_struct *ec_query_wq;
>
> --

Applied as 5.16-rc material with rewritten changelog and subject, thanks!