linux-kernel - Re: [RESEND PATCH v2] string: uninline memcpy_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiUtTkstJiEwsedWLaq3WdjfW8=0JD6v0qLAFSfzfWBaA@mail.gmail.com>
Date:   Wed, 3 Nov 2021 11:34:05 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Kees Cook <keescook@...omium.org>,
        Andy Shevchenko <andy@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andy Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [RESEND PATCH v2] string: uninline memcpy_and_pad

On Wed, Nov 3, 2021 at 11:03 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> Either case, I'll wait for advice from Linus on how to proceed.

It's a completely unimportant function, used in a couple of places,
not performance-sensitive, not security-sensitive, and not worth any
kind of buffer size checking.

And it's breaking the build because being inline somehow confuses the compiler.

It gets out-of-lined.

Kees - once you have gotten all compilers fixed and everybody using
them, you can send a patch to make it inline again.

I estimate that is in about ten years or so.

             Linus