linux-kernel - Re: [PATCH v2] mm, slub: emit the "free" trace report before freeing memory in kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b15e0bd0-14f3-3fd3-87a5-fe1b0889ad0b@huawei.com>
Date:   Wed, 3 Nov 2021 11:39:40 +0800
From:   Yunfeng Ye <yeyunfeng@...wei.com>
To:     Vlastimil Babka <vbabka@...e.cz>,
        Tang Yizhou <tangyizhou@...wei.com>, <cl@...ux.com>,
        <penberg@...nel.org>, <rientjes@...gle.com>,
        <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
CC:     <jhubbard@...dia.com>, <songmuchun@...edance.com>,
        <willy@...radead.org>, <wuxu.wu@...wei.com>,
        Hewenliang <hewenliang4@...wei.com>
Subject: Re: [PATCH v2] mm, slub: emit the "free" trace report before freeing
 memory in kmem_cache_free()



On 2021/11/2 22:39, Vlastimil Babka wrote:
> On 11/2/21 14:53, Tang Yizhou wrote:
>> On 2021/11/2 19:43, Yunfeng Ye wrote:
>>> --- a/mm/slub.c
>>> +++ b/mm/slub.c
>>> @@ -3526,8 +3526,8 @@ void kmem_cache_free(struct kmem_cache *s, void *x)
>>>  	s = cache_from_obj(s, x);
>>>  	if (!s)
>>>  		return;
>>> -	slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>>>  	trace_kmem_cache_free(_RET_IP_, x, s->name);
>>> +	slab_free(s, virt_to_head_page(x), x, NULL, 1, _RET_IP_);
>>>  }
>>
>> It seems that kmem_cache_free() in mm/slab.c has the same problem.
>> We can fix it. Thanks.
> 
> Doh, true. Should go best before the local_irq_save() there.
> And also kmem_cache_free() in mm/slob.c.
> 
Yes, I will fix the same problem together in the v3 patch.

Thanks.


> Interestingly kfree() is already OK in all 3 implementations.
> 
>>>  EXPORT_SYMBOL(kmem_cache_free);
>>>
>>
> 
> .
>