linux-kernel - Re: [PATCH] block: fix device_add_disk() kobject_create_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163596772995.186346.6961527014377680159.b4-ty@kernel.dk>
Date:   Wed, 03 Nov 2021 13:28:49 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Luis Chamberlain <mcgrof@...nel.org>, hare@...e.de,
        hch@...radead.org
Cc:     linux-block@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        kernel test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix device_add_disk() kobject_create_and_add() error handling

On Wed, 3 Nov 2021 09:40:23 -0700, Luis Chamberlain wrote:
> Commit 83cbce957446 ("block: add error handling for device_add_disk /
> add_disk") added error handling to device_add_disk(), however the goto
> label for the kobject_create_and_add() failure did not set the return
> value correctly, and so we can end up in a situation where
> kobject_create_and_add() fails but we report success.
> 
> 
> [...]

Applied, thanks!

[1/1] block: fix device_add_disk() kobject_create_and_add() error handling
      commit: 3554ce121f632db1f56f4e28dfe37da846617c9c

Best regards,
-- 
Jens Axboe