linux-kernel - Re: [PATCH RESEND] nbd: code clean for nbd_genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYOeYwPlLnn7JR+W@infradead.org>
Date:   Thu, 4 Nov 2021 01:48:35 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Wu Bo <wubo40@...wei.com>
Cc:     josef@...icpanda.com, axboe@...nel.dk, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org,
        linfeilong@...wei.com
Subject: Re: [PATCH RESEND] nbd: code clean for nbd_genl_status()

On Thu, Nov 04, 2021 at 12:38:23PM +0800, Wu Bo wrote:
>  	if (!reply_head) {
> -		nlmsg_free(reply);
>  		goto out;
>  	}

Please also drop the now pointless braces.

>  out:
> +	if (reply)
> +		nlmsg_free(reply);

Please just use a different label for just unlocking vs also freeing
the reply.