linux-kernel - Re: [PATCH] ARM: fix early early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXEsm1oK5uPqku7uJfF=FeKx1fEjTu80czZPguQPBO_z2w@mail.gmail.com>
Date:   Thu, 4 Nov 2021 10:07:36 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Jon Medhurst <tixy@...aro.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: fix early early_iounmap()

On Thu, 4 Nov 2021 at 01:46, Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
>
> Currently __set_fixmap() bails out with a warning when called in early boot
> from early_iounmap(). Fix it, and while at it, make the comment a bit easier
> to understand.
>
> Cc: <stable@...r.kernel.org>
> Fixes: b089c31c519c ("ARM: 8667/3: Fix memory attribute inconsistencies when using fixmap")
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  arch/arm/mm/mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index a4e006005107..274e4f73fd33 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -390,9 +390,9 @@ void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot)
>         BUILD_BUG_ON(__fix_to_virt(__end_of_fixed_addresses) < FIXADDR_START);
>         BUG_ON(idx >= __end_of_fixed_addresses);
>
> -       /* we only support device mappings until pgprot_kernel has been set */
> +       /* We support only device mappings before pgprot_kernel is set. */
>         if (WARN_ON(pgprot_val(prot) != pgprot_val(FIXMAP_PAGE_IO) &&
> -                   pgprot_val(pgprot_kernel) == 0))
> +                   pgprot_val(prot) && pgprot_val(pgprot_kernel) == 0))
>                 return;
>
>         if (pgprot_val(prot))
> --
> 2.30.2
>