linux-kernel - Re: [PATCH] crypto: hisilicon/hpre - use swap() to make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5913a9db-6cb7-6752-51ec-f6d09aa612ff@huawei.com>
Date:   Thu, 4 Nov 2021 17:34:06 +0800
From:   liulongfang <liulongfang@...wei.com>
To:     <davidcomponentone@...il.com>, <xuzaibo@...wei.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Yang Guang <yang.guang5@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] crypto: hisilicon/hpre - use swap() to make code cleaner

On 2021/11/4 14:19, davidcomponentone@...il.com wrote:
> From: Yang Guang <yang.guang5@....com.cn>
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Yang Guang <yang.guang5@....com.cn>
> ---
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> index a032c192ef1d..0f1724d355b8 100644
> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> @@ -1177,13 +1177,10 @@ static void hpre_rsa_exit_tfm(struct crypto_akcipher *tfm)
>  static void hpre_key_to_big_end(u8 *data, int len)
>  {
>  	int i, j;
> -	u8 tmp;
>  
>  	for (i = 0; i < len / 2; i++) {
>  		j = len - i - 1;
> -		tmp = data[j];
> -		data[j] = data[i];
> -		data[i] = tmp;
> +		swap(data[j], data[i]);
>  	}
>  }
>  >
OK!
Thanks.

Longfang.